-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate to GitHub actions #720
Conversation
Signed-off-by: PoAn Yang <poan.yang@suse.com>
Signed-off-by: PoAn Yang <poan.yang@suse.com>
Hi @FrankYang0529 , shall we need to remove longhorn-ui/.github/mergify.yml Line 4 in 16db32e
|
- name: Login to Docker Hub | ||
uses: docker/login-action@v3 | ||
with: | ||
username: ${{ secrets.DOCKER_USERNAME }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just confirm, you will add secrets DOCKER_USERNAME
and DOCKER_PASSWORD
somewhere in github action, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, already setup in organization level secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for confirmation.
Yeah, we will do it after the PR is merged. Thanks. |
@a110605 We need to add unit tests in the PR check in the future, also for Harvester. |
@mergify backport v1.6.x |
✅ Backports have been created
|
@mergify backport v1.5.x |
✅ Backports have been created
|
longhorn/longhorn#8039